Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only]Adjust expected failures for remaining closed issues #1823

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Jun 24, 2021

Description:

Some of the expected failures are linked with some closed issues. So this PR adjusts the file such that the failing tests are linked with correct issues.

Related Issue:

@jasson99 jasson99 requested a review from labkode as a code owner June 24, 2021 11:59
@update-docs
Copy link

update-docs bot commented Jun 24, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jasson99 jasson99 marked this pull request as draft June 24, 2021 11:59
@jasson99 jasson99 changed the title [Tests_Only]Adjust expected failures for remaining closed issues [Tests-Only]Adjust expected failures for remaining closed issues Jun 25, 2021
@phil-davis
Copy link
Contributor

@jasson99 is this ready?

@jasson99 jasson99 force-pushed the remainingAdjustments branch 2 times, most recently from 882b6a0 to 2df0051 Compare June 29, 2021 11:39
@jasson99 jasson99 force-pushed the remainingAdjustments branch 3 times, most recently from 3a572a4 to a3c09a4 Compare June 30, 2021 06:59
@jasson99 jasson99 marked this pull request as ready for review June 30, 2021 07:01
@phil-davis
Copy link
Contributor

@jasson99 other PRs have just been merged. Please rebase this so we can be sure that CI passes.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis
Copy link
Contributor

@jasson99 please make sure to apply the same/similar changes in owncloud/ocis so that all the expected-failures files have up-to-date links.

@ishank011 ishank011 merged commit de779ca into cs3org:master Jun 30, 2021
@phil-davis phil-davis deleted the remainingAdjustments branch June 30, 2021 11:11
labkode pushed a commit to glpatcern/reva that referenced this pull request Jul 1, 2021
thmour pushed a commit to thmour/reva that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants