Implement listing favorites via the dav report API #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
C0rby
force-pushed
the
list-favorites
branch
from
fb8a755
to
6eee683
Compare
refs
requested changes
Sep 27, 2021
|
|
||
| // InMemoryManager implements the Manager interface to manage favorites using an in-memory storage. | ||
| type InMemoryManager struct { | ||
| favorites map[string]map[string]*provider.ResourceId |
There was a problem hiding this comment.
also mind that a map is not thread safe and will panic if concurrent writes. A mutex should guard against this.
There was a problem hiding this comment.
Yep, it won't work without a lock
C0rby
force-pushed
the
list-favorites
branch
from
6eee683
to
053d660
Compare
butonic
previously approved these changes
Sep 30, 2021
ishank011
reviewed
Oct 4, 2021
|
@ishank011, it was agreed that this is just the short-term solution and a more future proof solution will follow. See #2036 |
|
@C0rby thanks! Can you add the mutex protection? We can merge it then |
ishank011
previously approved these changes
Oct 5, 2021
refs
previously approved these changes
Oct 5, 2021
|
@C0rby can you take a look at the failing tests, please? |
|
Yeah, I'm on it. |
added 2 commits
October 5, 2021 12:43
I added filter-files to the dav REPORT API. This enables the listing of favorites.
ishank011
approved these changes
Oct 5, 2021
wkloucek
added a commit
to owncloud/ocis
that referenced
this pull request
Oct 6, 2021
9 tasks
wkloucek
added a commit
to owncloud/ocis
that referenced
this pull request
Oct 6, 2021
wkloucek
added a commit
to owncloud/ocis
that referenced
this pull request
Oct 6, 2021
[full-ci] fix unexpected passes for cs3org/reva#2086
ownclouders
pushed a commit
to owncloud/ocis
that referenced
this pull request
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added filter-files to the dav REPORT API. This enables the listing of
favorites.
This is the rework of #2071
See #2071 (comment).