Make sure /app/new takes target as absolute path #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
force-pushed
the
app-abspath
branch
from
f6a6d77
to
8ccff70
Compare
|
@ishank011 @glpatcern can we go forward with #2210? It should also fix this problem |
ishank011
reviewed
Nov 26, 2021
| @@ -153,6 +153,13 @@ func (s *svc) handleNew(w http.ResponseWriter, r *http.Request) { | |||
| return | |||
| } | |||
|
|
|||
| // TODO(lopresti) if target is relative, currently the gateway fails to identify a storage provider (?) | |||
There was a problem hiding this comment.
We do support relative references but I don’t know if web can work with those
For now, it’s good enough
ishank011
approved these changes
Nov 26, 2021
thmour
pushed a commit
to thmour/reva
that referenced
this pull request
Nov 26, 2021
9 tasks
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mini-PR to make the
targetparameter absolute (by prepending/if missing).The real issue here is that a relative
targetseems to make the gateway fail to identify a storage provider, and theInitiateFileUploadrequest fails withCODE_INTERNAL. And the web frontend happened to send requests with relative paths.Independently from fixing the web frontend, this patch protects the app provider.