Share manager migration #2911
Merged
Share manager migration #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
aduffeck
force-pushed
the
share-manager-migration
branch
from
0d0fc81
to
cc4bf81
Compare
aduffeck
force-pushed
the
share-manager-migration
branch
from
2cf28f9
to
0e647d0
Compare
aduffeck
force-pushed
the
share-manager-migration
branch
from
0e647d0
to
4795230
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
looking good! Is there a CLI to Load and Dump? I don't see where they are used beside the tests... Can you link to it? |
|
@butonic I have a branch which adds according migration commands to the ocis cli at https://github.com/aduffeck/ocis/commits/migrate-shares |
butonic
approved these changes
Jun 20, 2022
40 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new interfaces for dumpable and loadable share managers and implements dumping shares from the
jsonand loading dumps intocs3manager.