Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a jsoncs3 share manager #3148

Merged
merged 95 commits into from
Aug 23, 2022
Merged

Add a jsoncs3 share manager #3148

merged 95 commits into from
Aug 23, 2022

Conversation

aduffeck
Copy link
Contributor

@aduffeck aduffeck commented Aug 11, 2022 •
edited

This PR adds a new jsoncs3 share manager which splits the json file per storage space and caches data locally.

@update-docs
Copy link

update-docs bot commented Aug 11, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

butonic and others added 29 commits August 19, 2022 09:22
@butonic @aduffeck
initial jsoncs3 share manager
a5d6c5b 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
explore and note thoughts
ab2bfd3 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
more thoughts
f82c775 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@aduffeck
Lay some groundwork
9fe892f
@aduffeck
WIP
ac6751c
@butonic @aduffeck
implement getByKey and getByID
b080c70 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
GetShare
1a70643 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
Unshare
7fa2872 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
UpdateShare
afa977e 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
ListShares without filter
f5e83fc 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@aduffeck
DRY up tests
449ee9b
@aduffeck
Extend and cleanup test suite
defcb21
@aduffeck
Mininmal implementation for ListReceivedShares
4b800a2
@aduffeck
Add a basic cache for the received shares
b7a937c
@butonic @aduffeck
UpdateReceivedShare
da4a239 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
filter by id
0db511f 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
initial group accessCache
33ac3a2 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
thoughts
247070e 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
refactor shareCache
8eee472 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
add todos for permission changes
3757085 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
add sharecache implementation
06b3f0a 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
use group cache for pending state
005831b 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
add plan for storage
af8127e 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
add storage.Stat() and sketch out refresh from disk
781a526 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
read user cache from storage
b94855b 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
write user share cache on share
f25e074 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
persist on unshare
61d7311 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
extract set/removeCreatedCache
e24690e 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic @aduffeck
replace provider space gcache with map
d1f3637 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
add timestamps to precondition failed error
285e35c 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@lgtm-com
Copy link

lgtm-com bot commented Aug 22, 2022

This pull request introduces 2 alerts when merging 285e35c into 15d0666 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable

@butonic
revert mtime change on error
18f2d66 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@lgtm-com
Copy link

lgtm-com bot commented Aug 22, 2022

This pull request introduces 2 alerts when merging 18f2d66 into 15d0666 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Aug 22, 2022

This pull request introduces 2 alerts when merging 9f3c7b3 into 15d0666 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable

@butonic
add missing headers
b41b20f 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@lgtm-com
Copy link

lgtm-com bot commented Aug 22, 2022

This pull request introduces 2 alerts when merging b41b20f into 15d0666 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable

@butonic
Copy link
Contributor

butonic commented Aug 22, 2022

flaky concurrency test tracked in #3166

This was referenced Aug 22, 2022
Closed
Closed
@lgtm-com
Copy link

lgtm-com bot commented Aug 22, 2022

This pull request introduces 2 alerts when merging 5b7a094 into 15d0666 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Aug 22, 2022

This pull request introduces 1 alert when merging dc16651 into 15d0666 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@butonic
lint fixes
2e77af4 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic mentioned this pull request Aug 23, 2022
Closed
@butonic
fix nextcloud mock
033ae61 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic mentioned this pull request Aug 23, 2022
Merged
@butonic butonic self-assigned this Aug 23, 2022
@butonic butonic mentioned this pull request Aug 23, 2022
Merged
butonic
butonic approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation works as designed. 🚀

@butonic butonic merged commit bc50fed into cs3org:edge Aug 23, 2022
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees

@butonic butonic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aduffeck @butonic