Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dockerfile.revad-eos #3197

Merged
merged 13 commits into from
Dec 2, 2022
Merged

Conversation

ebocchi
Copy link
Contributor

@ebocchi ebocchi commented Sep 6, 2022

  • Use EOS 4.8.91
  • Bring back multi-stage build
  • Copy the resulting revad from the builder container

Resulting image size (unpacked on disk) is 2.59GB

  • eos-all:4.8.91 is 2.47GB
  • existing revad:latest-eos is 6.18GB

@update-docs
Copy link

update-docs bot commented Sep 6, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ebocchi ebocchi requested review from glpatcern and a team as code owners September 7, 2022 06:38
glpatcern
glpatcern previously approved these changes Sep 7, 2022
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jimil749
Copy link
Contributor

/cc @SamuAlfageme can we get this merged, so that it can be used for Sciencebox?

Copy link
Contributor

@SamuAlfageme SamuAlfageme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebocchi the CI was failing due to a missing x-ref to the GitHub PR

changelog/unreleased/dockerfile.revad-eos.md Outdated Show resolved Hide resolved
jimil749 and others added 2 commits November 18, 2022 10:09
Co-authored-by: Samuel Alfageme <samuel.alfageme@gmail.com>
@glpatcern
Copy link
Member

@ebocchi I'm sorry to have screwed part of this change :-P can you please rebase it on top of master ?

SamuAlfageme
SamuAlfageme previously approved these changes Dec 2, 2022
@ebocchi
Copy link
Contributor Author

ebocchi commented Dec 2, 2022

@glpatcern
Rebased against master. Should be good to go now ;)

@gmgigi96
Copy link
Member

gmgigi96 commented Dec 2, 2022

@ebocchi can you fix the linter (Codacy Static Code Analysis)?

@ebocchi
Copy link
Contributor Author

ebocchi commented Dec 2, 2022

As per @glpatcern, going back to eos-client-4.8.91-1.el7.cern.x86_64 as the only package needed is eos-client.
eos-client-4.8.91-1.el7.cern.x86_64 include:

# rpm -qa | grep ^eos | sort
eos-client-4.8.91-1.el7.cern.x86_64
eos-folly-2019.11.11.00-1.el7.cern.x86_64
eos-folly-deps-2019.11.11.00-1.el7.cern.x86_64
eos-fusex-4.8.91-1.el7.cern.x86_64
eos-fusex-core-4.8.91-1.el7.cern.x86_64
eos-fusex-selinux-4.8.91-1.el7.cern.x86_64
eos-protobuf3-3.5.1-5.el7.cern.eos.x86_64
eos-xrootd-4.12.8-1.el7.cern.x86_64

glpatcern
glpatcern previously approved these changes Dec 2, 2022
@gmgigi96 gmgigi96 merged commit c3e9948 into cs3org:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants