Create OCM share from sciencemesh service #3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpatcern
previously approved these changes
Mar 1, 2023
There was a problem hiding this comment.
@michielbdejong now /ocm/send is /sciencemesh/create-share !
michielbdejong
previously approved these changes
Mar 1, 2023
michielbdejong
pushed a commit
to pondersource/oc-sciencemesh
that referenced
this pull request
Mar 2, 2023
|
FYI I merged this branch into https://github.com/cs3org/reva/tree/sciencemesh-dev |
glpatcern
requested changes
May 4, 2023
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
The PR is now ready |
glpatcern
approved these changes
May 4, 2023
gmgigi96
added a commit
to gmgigi96/reva
that referenced
this pull request
Jun 5, 2023
* create share from sciencemesh service * make /create-share unprotected * add changelog * fix linter! * Update internal/http/services/sciencemesh/share.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * Update internal/http/services/sciencemesh/share.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * Update internal/http/services/sciencemesh/sciencemesh.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * removed old code * fix import names --------- Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
gmgigi96
added a commit
to gmgigi96/reva
that referenced
this pull request
Jun 28, 2023
* create share from sciencemesh service * make /create-share unprotected * add changelog * fix linter! * Update internal/http/services/sciencemesh/share.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * Update internal/http/services/sciencemesh/share.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * Update internal/http/services/sciencemesh/sciencemesh.go Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * removed old code * fix import names --------- Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the recent refactor of the OCM service the endpoint /ocm/share was removed, this PR re-add it back.
Closes pondersource/sciencemesh-php#166