Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto create home folder if it is missing in eos #436

Closed
wants to merge 6 commits into from

Conversation

madsi1m
Copy link
Contributor

@madsi1m madsi1m commented Dec 13, 2019

No description provided.

@labkode
Copy link
Member

labkode commented Dec 13, 2019

Uhmm this responsibility should be of the gateway on the GetHome call, @butonic what you think?

I prefer to create home directories on https://github.com/cs3org/reva/blob/master/internal/grpc/services/storageregistry/storageregistry.go#L125
maybe even having a new CS3 API method named CreateHome?

@madsi1m
Copy link
Contributor Author

madsi1m commented Dec 13, 2019

Would be good to have this feature for all storage providers. I know the owncloud storage provider does it already. The trick is to only create it for home directories.

@labkode
Copy link
Member

labkode commented Dec 18, 2019

I will add the creation of the home logic when the user does the login, I think that is the place. We've been doing it like that and OC also in the PHP code in the setupFS method.

@madsi1m
Copy link
Contributor Author

madsi1m commented Dec 18, 2019

Sounds good. Thinking a little further into the future, I foresee some storage’s that we will not want user home folders created on and some that we will. Can we include a config option in the storage provider config to allow/disallow this?

@labkode
Copy link
Member

labkode commented Dec 18, 2019

That is the reason why we have a GetHome call, so only Storage Providers that are returned in that call will have a home created.

@labkode
Copy link
Member

labkode commented Jan 15, 2020

Closed in #469 once merged

@labkode labkode closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants