publicsshareprovider: Allow creating/updating public links on received shares #4429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d shares The permission check when trying to create an internal link of a received share did not work correctly. Internal links have all Permissions set to false. The 'SufficientCS3Permissions' method treats an all-false PermissionSet as a deny grant, which a wrong in the public link case. We can skip the 'SufficientCS3Permissions' check for internal links however, since the creation of a internal link should always be allowed as long as the user has the 'AddGrant' permission. Related Issue: owncloud/ocis#8039
rhafer
force-pushed
the
ocisissue/8039
branch
from
815f226
to
cf45f36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permission check when trying to create an internal link of a received share did not work correctly. Internal links have all Permissions set to false. The 'SufficientCS3Permissions' method treats an all-false PermissionSet as a deny grant, which a wrong in the public link case.
We can skip the 'SufficientCS3Permissions' check for internal links however, since the creation of a internal link should always be allowed as long as the user has the 'AddGrant' permission.
Related Issue: owncloud/ocis#8039