Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publicsshareprovider: Allow creating/updating public links on received shares #4429

Merged
merged 1 commit into from Dec 21, 2023

Commits on Dec 21, 2023

  1. publicsshareprovider: Allow creating/updating public links on receive…

    …d shares
    
    The permission check when trying to create an internal link of a received share
    did not work correctly. Internal links have all Permissions set to false. The
    'SufficientCS3Permissions' method treats an all-false PermissionSet as a deny grant,
    which a wrong in the public link case.
    We can skip the 'SufficientCS3Permissions' check for internal links however, since
    the creation of a internal link should always be allowed as long as the user has the
    'AddGrant' permission.
    
    Related Issue: owncloud/ocis#8039
    rhafer committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    cf45f36 View commit details
    Browse the repository at this point in the history