fix: ocs handles the mount_point on its own #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschade
force-pushed
the
ocs-mount-point-handling
branch
from
b753544
to
aba128e
Compare
fschade
force-pushed
the
ocs-mount-point-handling
branch
from
b753544
to
aba128e
Compare
|
@nirajacharya2 can you check the ci, looks like #4724 introduced some unexpected passes |
|
This PR should do it #4729 |
fschade
force-pushed
the
ocs-mount-point-handling
branch
from
b753544
to
2987785
Compare
rhafer
approved these changes
Jun 18, 2024
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocs updates unmountedShares at the same time as a received share is accepted, therefore the mount_point handling is entirely done there too.