Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mario checks to look for trailing whitespace and advise accordingly #17

Open
dmalan opened this issue Sep 20, 2017 · 2 comments
Open
Assignees

Comments

@dmalan
Copy link
Member

dmalan commented Sep 20, 2017

It would be handy to mention on the guidelines that you don't need to add spaces on the other side of the right hand column to make the spaces and pound signs symmetrical (i.e., that it's ragged right).

screen shot 2017-09-16 at 22 04 33

@brianyu28
Copy link
Member

We actually already do this, per:

https://github.com/cs50/checks/blob/master/cs50/2017/fall/mario/less/check50/__init__.py#L76

See the detailed link in the screenshot for what that looks like:

https://cs50.me/checks/e9a0cb104971aa13e0370849151e1660ee7bfaf9

@dmalan
Copy link
Member Author

dmalan commented Sep 20, 2017

Ah, hm, so it's the abbreviated output that's referred to. Should we perhaps highlight spaces in the web output to make things more clear?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants