Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import to instance goes to wrong place #217

Closed
csatt opened this issue Aug 5, 2023 · 0 comments
Closed

Import to instance goes to wrong place #217

csatt opened this issue Aug 5, 2023 · 0 comments
Assignees
Labels

Comments

@csatt
Copy link
Owner

csatt commented Aug 5, 2023

This is an obscure bug. I found it while testing the pathlib refactor, but it exists in the released app.

Repro:

  • Open an instance GUI from the Instances menu (e.g. Instances->Inst_A)
  • Open the Results Wizard
  • Navigate to a different path by clicking on the path at the top of the dialog
  • Select a run
  • Click the Import button
    The dialog confirms the copy, but the destination path is something like:
    /Users/csatt/Library/Application Support/IV_Swinger2/inst/IV_Swinger2

That isn't where it should go, and it isn't visible from the Results Wizard.

It's a little strange to be importing runs into an instance, but there's a use case: There could be runs that were performed before the instance was created, but belong to that instance. The user would want to import them into the instance.

The fix should be to just import runs to the instance folder.

@csatt csatt added the bug label Aug 5, 2023
@csatt csatt self-assigned this Aug 5, 2023
csatt added a commit that referenced this issue Aug 5, 2023
import_results() method: If import is to an instance, set the copy destination to the import folder itself instead of its parent.
get_dest_dir() method: if destination is an instance, don't add the app name or source directory instance path.
display_copy_summary() method: display the correct path (don't append IV_Swinger2) if the destination is an instance
@csatt csatt closed this as completed Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant