Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could I submit a PR that skips lag embedding for multivariate series #23

Closed
williamgilpin opened this issue May 28, 2021 · 2 comments
Closed

Comments

@williamgilpin
Copy link

Hello, I've been using a modified version of your code to calculate fractal dimension, lyapunov exponents, etc based on a custom embedding method. Would this be something valuable to include in the main repo? If so, I can put together a PR.

The basic structure is pretty simple: if the passed time series appears to be multivariate, then skip creating a lagged embedding.

Thanks very much for this amazing library.

@CSchoel
Copy link
Owner

CSchoel commented May 30, 2021

Hi, @williamgilpin . Thank you very much for your offer! ❤️ I would very much appreciate this pull request. I think this would also open up the algorithms to be used with multivariate data in general, not just with a custom embedding. I considered doing this myself for some time, but I currently have almost no time at all for developing nolds.

If you want to do this, I would be very glad if you could

  • base your PR on the dev branch, since there is quite a bit of work currently sitting there that is almost finished and I would like to avoid conflicts with these changes.
  • mention the option to pass multivariate data in the docstring of the algorithms (I think it would suffice to add a note to the main data parameter).
  • and add a small test case in https://github.com/CSchoel/nolds/blob/dev/nolds/test_measures.py that uses the new feature.

I will check your PR as fast as I can, but as already mentioned I currently have very little time for nolds, since I am only a few months away from finishing my PhD thesis. So I apologize in advance if it should take longer.

@williamgilpin
Copy link
Author

Great! I will start putting something together. I will make sure to base and periodically check the dev branch to avoid any conflicts. Best of luck with finishing your PhD!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants