Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new filters #1

Closed
themiyan opened this issue Nov 6, 2017 · 3 comments
Closed

Adding new filters #1

themiyan opened this issue Nov 6, 2017 · 3 comments
Labels
enhancement fixed in v1.1

Comments

@themiyan
Copy link

themiyan commented Nov 6, 2017

Hi Corentin,

Would it be possible to add a small section on the documentation on adding new filters? It seems there are some minor differences between the IDL and C++ versions in how the filters are identified from the database?
@cschreib
Copy link
Owner

cschreib commented Nov 8, 2017

Will do as soon as I find the time! (within a week) Thanks for the suggestion.

@cschreib
Copy link
Owner

cschreib commented Nov 8, 2017

Section added in the README! In addition, I've re-written the filter loading code to be more consistent with FAST and EAzY. Let me know if this still doesn't work as you would expect. (relevant commit: 41f8e50)

@cschreib cschreib closed this as completed Nov 8, 2017
@cschreib
Copy link
Owner

cschreib commented Nov 8, 2017

This fix is now included in the v1.1 release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement fixed in v1.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cschreib @themiyan