Read meta data from environment #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to avoid the system call inside that class. I'd suggest creating a class to represent the student data and pass it to the Context. Check the AndyOnWebLab class, that's the main method that Weblab calls! |
| @@ -98,7 +98,8 @@ private void writeAnalyticsFile(Context ctx, Result result) { | |||
| return; | |||
|
|
|||
| Submission submission = new Submission( | |||
| new SubmissionMetaData(System.getenv("WL_COURSE"), System.getenv("WL_STUDENT"), System.getenv("WL_ASSIGNMENT_TITLE"), ctx.getAction()), | |||
| ctx.getAction(), | |||
| ctx.getMetaData(), | |||
There was a problem hiding this comment.
I'd just rename the method to getSubmissionMetaData to make it more explicit!
mauricioaniche
approved these changes
Nov 23, 2021
yoonhwanjeong
force-pushed
the
read-meta-data
branch
from
d937115
to
b5fa833
Compare
This was referenced Dec 8, 2021
This was referenced Dec 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read meta data from environment according to this.
I do not know how to run Andy in WebLab so I would like someone else to check that the output has correct meta data.