Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pagination because it's completely broken #193

Closed
cow1337killer3 opened this issue Apr 2, 2024 · 4 comments
Closed

Remove pagination because it's completely broken #193

cow1337killer3 opened this issue Apr 2, 2024 · 4 comments

Comments

@cow1337killer3
Copy link

Navigating result pages does not work at all. Get rid of the pagination, use the Steam website's builtin pagination, and just have the extension display the float values.

@Step7750
Copy link
Member

Step7750 commented Apr 2, 2024

It's very likely that what is actually "broken" is that Steam is taking too long to respond since you set the page size to 100.

Try out a page size of 10 and report back.

@cow1337killer3
Copy link
Author

cow1337killer3 commented Apr 2, 2024

It's very likely that what is actually "broken" is that Steam is taking too long to respond since you set the page size to 100.

Try out a page size of 10 and report back.

Yup, so that turns out to be the case... looks like Steam is very stingy with the speed of requests that we can make.

However, I think it'd be very helpful if the extension could continuously retry the request (with a timeout etc) if it fails. Or at least have some kind of message pop up saying that Steam refused the request, so the user knows what's happening.

Another related problem seems to sometimes happen on initial page #1 loads when the "items per page" is greater than the default 10... I guess it fails to retrieve all of the multiple pages requested, and instead shows the page with pagination for 10-items-per-page. A message/retry could also be helpful for this case, since the user won't know why it's only showing 10 items per page when they selected 25/50/100.

@SaloEater
Copy link

SaloEater commented Sep 16, 2024

I added some visual feedback about page loading on recent PR #251. This indication works and I now do understand when steam is bitching about too much requests

@Step7750
Copy link
Member

Seems like Steam has put more work into improving the responsiveness of SCM -- so I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants