Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Readme: Hierarchical Shrinkage Doesn't Support HistGradientBoostingRegressor #137

Closed
bridgream opened this issue Oct 14, 2022 · 1 comment

Comments

@bridgream
Copy link

The readme page claims that hierarchical shrinkage supports any sklearn tree-based model, but in reality it only works with sklearn.ensemble.GradientBoostingRegressor and sklearn.ensemble.GradientBoostingClassifier. When used with sklearn.ensemble.HistGradientBoostingRegressor, the _shrink method is nullified because neither of the two conditions is true:
https://github.com/csinva/imodels/blob/master/imodels/tree/hierarchical_shrinkage.py#L125-L127 . This is same for HistGradientBoostingClassifier.

We should either add support to hist boosting trees, or clarify this in the readme.

@csinva
Copy link
Owner

csinva commented Oct 17, 2022

Thanks for pointing this out! I've just updated this in the readme and we'll try and support HistGradientBoostingRegressor soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants