Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIGS dtreeviz support broken #161

Closed
csinva opened this issue Feb 13, 2023 · 5 comments
Closed

FIGS dtreeviz support broken #161

csinva opened this issue Feb 13, 2023 · 5 comments
Assignees

Comments

@csinva
Copy link
Owner

csinva commented Feb 13, 2023

Hey @mepland, seems like the FIGS+dtreeviz integrations is broken in newer versions of dtreeviz.

The current demo works for me with dtreeviz-1.3.7 but for newer versions I get AttributeError: module 'dtreeviz.trees' has no attribute 'dtreeviz'.

Any idea on how to fix?

@mepland
Copy link
Collaborator

mepland commented Feb 14, 2023

Hi @csinva!

dtreeviz had a major refactor last month which broke the old workflow. I am contributing to the package and will probably make a FIGS specific shadow tree class to implement the custom leaf weights / values, see parrt/dtreeviz#239. I was planning on updating the FIGS_viz_demo.ipynb notebook once I had that done, but things have been a bit busy for me recently so it may be a few weeks.

The existing FIGS extract_sklearn_tree_from_figs code should work with the current release of dtreeviz though as a sklearn tree, just with the new dtreeviz api calls.

@mepland mepland self-assigned this Feb 14, 2023
@csinva
Copy link
Owner Author

csinva commented Feb 14, 2023

Awesome, thanks for the update!

@paulsendavidjay
Copy link

Hi @mepland,

Could you elaborate on your Feb 13 comment? Recipe for getting the FIGS notebook example to work?

Alternatively, is there fixed set of instructions for setting up a conda env to be able to run the notebooks in this repo successfully? I have different problems with different versions.

Thanks,
David

@mepland
Copy link
Collaborator

mepland commented Oct 10, 2023

Hi @paulsendavidjay, please see my #158 PR which has a figs_demo.ipynb notebook that works with the current releases of sklearn and dtreeviz.

@mepland
Copy link
Collaborator

mepland commented Oct 12, 2023

Closing issue as addressed by #158.

@mepland mepland closed this as completed Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants