Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing support #24

Open
ledhed2222 opened this issue Feb 12, 2021 · 4 comments
Open

Typing support #24

ledhed2222 opened this issue Feb 12, 2021 · 4 comments

Comments

@ledhed2222
Copy link
Contributor

Hi there - I'm working with a team that's using ECPy as a dependency. We'd like to add types to ECPy. Is it possible to add types given the versions you support?

@cslashm
Copy link
Owner

cslashm commented Feb 12, 2021

Yes you can make any PR and I ll' review it and merge it if appropriate.
You can also PM me if you want to discuss, but it's better to have tech discussion here.
Can you give more detail about what you want/need to add

@ledhed2222
Copy link
Contributor Author

happy to make the PR - but need some info:

  1. what versions of python are you committed to supporting? looks like 2.7 and 3.x. Can you confirm? Is it really necessary to keep 2.7 compatibility?
  2. looks like there is no concept of developer dependencies using poetry for example. to do this, we'd want to have type checking be verified automatically somehow. one option is using pre-commit with mypy. this would allow us to avoid the use of CI

@ledhed2222
Copy link
Contributor Author

bump :)

@cslashm
Copy link
Owner

cslashm commented Apr 6, 2021

  1. You can remove 2.7 compat
  2. Hmm...I'm not familiar with those techno, but they seem interesting, Let's go for using that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants