Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one command executed because index is moved up once #6

Closed
csm10495 opened this issue Jul 20, 2017 · 0 comments
Closed

Only one command executed because index is moved up once #6

csm10495 opened this issue Jul 20, 2017 · 0 comments
Labels

Comments

@csm10495
Copy link
Owner

Controller::checkForChanges() should update via setIndex at the end of processing. We should use a while loop to pass all commands in the delta to processCommandAndPostCompletion().

Right now it only does on command max per check and will skip over all but one here.

Probably a good place to chance to possibly update Queue to have a head/tail field. The idea would be that the head would move up one command at a time until it == tail.

@csm10495 csm10495 added the bug label Jul 20, 2017
csm10495 pushed a commit that referenced this issue Jul 21, 2017
…l upward more than once. The Queue is much smarterf now and can increment it's head with wrap around.
csm10495 added a commit that referenced this issue Jul 29, 2017
…l upward more than once. The Queue is much smarterf now and can increment it's head with wrap around.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant