-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partial with bootstrap panel markup #11
base: master
Are you sure you want to change the base?
Conversation
Thanks for this! I gave it a test and the X is rendering a bit below the title bar on the latest Bootstrap. Feel free to take a look by grabbing https://github.com/csm123/starburst-bootstrap-example, running |
No problem! I thought a panel might be a nice alternative for anyone who might want to display more information. I followed the steps to get the |
Thanks! Make sure you go to /pages/home and create an account and login,
|
Oh ok yeah that's why I couldn't see it - I wasn't logged in. When I went to the /pages/home route in the browser, I just saw the |
Ok so I did some reading about Devise and I was able to log in and see the misaligned close button. I moved the close button markup above the header markup and added a |
@csm123 I looked at the build details from Travis CI, and it looks like some of the build jobs failed and some of them succeeded. I checked the logs for the jobs that failed, and each time the error was
It looks like the build jobs failed when using Ruby 1.9.3 and 2.1.3, but succeeded when using Ruby 2.0.0. Do you know why this might happen for some of the jobs but not all of them? |
This change builds on the existing partial that using Bootstrap compatible markup, only using a panel instead of an alert. A panel would be useful for anyone who may want to insert the announcement somewhere in the UI with a little more screen real estate.
I think the panel heading provides a good spot for an icon, a title, and the close button that dismisses the announcement. I could later modify this to include the title of the announcement as the title of the panel as well, but thought just simply Announcement would be good for the panel title for now.