Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build process more modular #796

Closed
algorev opened this issue May 23, 2017 · 9 comments
Closed

Make build process more modular #796

algorev opened this issue May 23, 2017 · 9 comments

Comments

@algorev
Copy link

algorev commented May 23, 2017

The build process should be made more modular and not force users to compile bindings.
Those should come as a build option.

@vlazzarini
Copy link
Member

Not quite sure what the request is, cmake is pretty modular. If you set up a custom.cmake with the paths, build variables etc., you can customise the linking as needed. However, if you know exactly what you want, a pull request would be helpful.

@stekyne
Copy link
Member

stekyne commented May 23, 2017

I think the only hard requirement is libsndfile. The other dependencies are optional. It might be an idea to create some preset scripts for a minimal build, installer (full) build, etc.

@algorev
Copy link
Author

algorev commented May 23, 2017 via email

@stekyne
Copy link
Member

stekyne commented May 23, 2017

Well cmake-gui will show you the options available and you can select/deselect easily then. You can specify them on the command line also.

If cmake can't detect the dependencies it will usually just remove those features from the build anyway. It should only fail for a small number of dependencies (like libsndfile), if it can't find them.

@algorev
Copy link
Author

algorev commented May 23, 2017 via email

@stekyne
Copy link
Member

stekyne commented May 23, 2017

If you don't need it then add "-DBUILD_PYTHON_OPCODES=0" to your cmake command line. If you want to get it working then paste the log and I'll try and help.

@gogins
Copy link
Contributor

gogins commented May 23, 2017 via email

@stekyne
Copy link
Member

stekyne commented May 23, 2017

Setting the properties does work from the custom cmake files, it's working now for the MSVC build. However, you need to use absolute paths or else it get's messed up if relative paths are used. So if you're setting paths, it's probably best to do it on the command line.

@stekyne
Copy link
Member

stekyne commented Nov 27, 2017

Closing as there doesn't seem to be any tangible request after discussing it.

@stekyne stekyne closed this as completed Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants