Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue in Sublime plugin #56

Closed
wants to merge 1 commit into from
Closed

Fixed issue in Sublime plugin #56

wants to merge 1 commit into from

Conversation

larikov
Copy link

@larikov larikov commented Apr 30, 2012

Sublime gives an error when only rules selected

Notice: Undefined variable: end_of_code in ... Packages/Csscomb/csscomb/libs/csscomb.php on line 972 

fixed by initializing variable end_of_code

@miripiruni
Copy link
Contributor

Дубль #52

@miripiruni miripiruni closed this May 3, 2012
@larikov
Copy link
Author

larikov commented May 3, 2012

Это не дубль, это пулл реквест, который фиксит багу, описанную в #52

@miripiruni
Copy link
Contributor

Я вижу. Только это пулл реквест не туда.

Исходник CSScomb в /src/csscomb.php, и он уже автоматически собирается в каждый из плагинов. То есть фикс годится, просто я напишу его в исходник.

@miripiruni
Copy link
Contributor

К тому же как показал детальный анализ кода вокруг — это был неудачный вариант пофиксить проблему.

miripiruni added a commit that referenced this pull request May 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants