Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-jss]: wrong 'transition' parse #1204

Closed
chrisands opened this issue Oct 3, 2019 · 5 comments
Closed

[react-jss]: wrong 'transition' parse #1204

chrisands opened this issue Oct 3, 2019 · 5 comments
Assignees
@AleshaOleg
Labels
bug It went crazy and killed everyone. complexity:moderate We talked about it, you can do it! important The thing you do when you wake up!

Comments

@chrisands
Copy link
Contributor

chrisands commented Oct 3, 2019 •
edited
Loading

Expected behavior:
transition: 'ease-in-out 0.3s' parses to transition: ease-in-out 0.3s or

Describe the bug:
transition 'ease-in-out 0.3s' parses to transition: false 0.3s ease 0s

Note:
If don't use function in createUseStyles than transition: 'ease-in-out 0.3s parses to transition: false 0.3s

Codesandbox link:
https://codesandbox.io/s/stoic-hoover-91hdt

Versions (please complete the following information):

  • jss: 10.0
  • Browser [e.g. chrome, safari]: firefox, chrome
  • OS [e.g. Windows, macOS]: macOS

I would suggest that this is not react-jss problem, but jss parser.
@kof
Copy link
Member

kof commented Oct 3, 2019

I think we fixed something very similar a while ago in prefixer cc @AleshaOleg

@kof kof added bug It went crazy and killed everyone. complexity:moderate We talked about it, you can do it! important The thing you do when you wake up! labels Oct 3, 2019
@AleshaOleg AleshaOleg self-assigned this Oct 3, 2019
@AleshaOleg
Copy link
Member

Just another case for transition/transition-property properties, which is not covered. @chrisands thanks!

Here is PR: cssinjs/css-vendor#169

@AleshaOleg
Copy link
Member

Fixed in css-vendor@2.0.7

@AleshaOleg
Copy link
Member

@kof #1208

@AleshaOleg AleshaOleg mentioned this issue Oct 3, 2019
Merged
@kof
Copy link
Member

kof commented Nov 25, 2019

fixed, gonna be in 10.0.1

@kof kof closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AleshaOleg AleshaOleg

Labels
bug It went crazy and killed everyone. complexity:moderate We talked about it, you can do it! important The thing you do when you wake up!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kof @AleshaOleg @chrisands