Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated CSS incorrect for @media blocks? #40

Closed
mihalik opened this issue Jan 29, 2015 · 4 comments
Closed

Generated CSS incorrect for @media blocks? #40

mihalik opened this issue Jan 29, 2015 · 4 comments
Labels
bug It went crazy and killed everyone.

Comments

@mihalik
Copy link

mihalik commented Jan 29, 2015

I noticed my media queries were not working after converting to jss and after a bit of digging, I noticed it was generating code like this:

@media (max-width: 600px) {
  .facet_sidebar: {
    display: none;
  }
}

The extra colon after .facet_sidebar is the issue. Looking at the code, there is an exception for @Keyframe to not include a colon but not @media. I don't think I'm familiar enough with CSS to know why this is in place so I'm filing a ticket rather than pull request.

@kof
Copy link
Member

kof commented Jan 29, 2015

Yeah, thanks!

@kof kof added the bug It went crazy and killed everyone. label Jan 29, 2015
@kof
Copy link
Member

kof commented Jan 29, 2015

Will fix it very soon.

@kof kof closed this as completed in 431c0a3 Jan 31, 2015
@kof
Copy link
Member

kof commented Jan 31, 2015

please let me know if it works for you now.

@mihalik
Copy link
Author

mihalik commented Feb 9, 2015

Seems good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It went crazy and killed everyone.
Projects
None yet
Development

No branches or pull requests

2 participants