Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-jss] Readd forwardRef support #800

Closed
HenriBeck opened this issue Aug 3, 2018 · 6 comments
Closed

[react-jss] Readd forwardRef support #800

HenriBeck opened this issue Aug 3, 2018 · 6 comments
Labels
complexity:moderate We talked about it, you can do it! feature request This will safe many lifes!

Comments

@HenriBeck
Copy link
Member

From @kof on June 12, 2018 8:52

It was removed due to issues with redux-connect and the fact that it needs a major release, see #255

Now we need to understand how redux-connect and similar can be supported.

Copied from original issue: cssinjs/react-jss#256
@HenriBeck HenriBeck added complexity:moderate We talked about it, you can do it! feature request This will safe many lifes! labels Aug 3, 2018
@HenriBeck
Copy link
Member Author

I don't think we can support react-redux in any way, rather we need to wait for react-redux to not check against a function and rather against a valid react element described here

@HenriBeck
Copy link
Member Author

From @kof on June 12, 2018 9:6

Yeah, but how can we release react-jss with forwardRef support without making it incompatible with so many react-redux versions?

@HenriBeck
Copy link
Member Author

I don't think we can.

@HenriBeck
Copy link
Member Author

From @kof on June 12, 2018 10:13

Lets release this change in a major version as soon as reduxjs/react-redux#914 is fixed

@HenriBeck HenriBeck changed the title Readd forwardRef support [react-jss] Readd forwardRef support Aug 3, 2018
@TrySound TrySound mentioned this issue Sep 4, 2018
Closed
13 tasks
@acatcalledfrank
Copy link

Looks like react-redux/issues/914 has been resolved so hopefully that's unblocked this?

@HenriBeck HenriBeck mentioned this issue Dec 22, 2018
Merged
@HenriBeck
Copy link
Member Author

This was implemented in #943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity:moderate We talked about it, you can do it! feature request This will safe many lifes!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acatcalledfrank @HenriBeck