-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to support react@16.0.0 #43
Comments
I think we should not have react in dependencies at all, it should be peerDependencies |
@iamstarkov do you know why we use it in dependencies? |
I created a branch and updated the dependencies to the latest version and updated
|
No, tests need devDependency, code needs peerDependency, they both can co-exist. |
That's correct. I was thinking |
@kof What needs to be done to get someone to pay attention to this? I'm happy to help out but can only do so if the maintainers are receptive. I see all the great work you're trying to do with |
@iamstarkov @oliviertassinari I'm happy to help make this repo compatible with React 16. Please let me know how I can contribute. @oliviertassinari don't you care about this for material-ui v1 ? |
@hburrows Material-UI doesn't rely on the package. |
@oliviertassinari |
@oliviertassinari Thanks for the quick response. I get what you're saying. From @kof I'm 👍 to removing |
Theming is a separate package for a reason. It is a common effort from multiple cssinjs projects in order to unify theming. It is used by emotion and the plan was we all agreed upon to use it in styled-components and glamorous and hopefully more. I guess the problem here is that nobody did the work of migrating as of right now. I have publishing rights in this package, so I will fix this at some point if nobody else does. In the meantime everyone is free to fork both projects and use them temporarily. |
@kof I can't see the win for react-jss. I'm very grateful to @iamstarkov for sharing his implementation. This saved me a lot of time with implementing a custom version for Material-UI. I have soon reached the limitation of the abstraction. By the way, I have opened three issues to provide feedback on those limitations. This plan doesn't seem to move forward (while the importance of any problem tends to increase over time):
I think that it's time to move on, it's just my humble opinion. |
I will try to get the admin rights for the repo and add more people so we can all move it forward. Otherwise we will just fork and move forward. |
i'll take care of everything |
i moved repo to cssinjs org |
so @kof is the admin now |
and ask him to add active contributors |
i think i cant handle long term oss, and im deeply sorry for you. i wish i would delegate the project earlier |
Don't worry @iamstarkov, get better and come back any time. |
As title says! :)
The text was updated successfully, but these errors were encountered: