Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csmock: add --scrub-on-exit option #154

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

lzaoral
Copy link
Member

@lzaoral lzaoral commented Feb 20, 2024

... to pass --scrub=all to the underlying mock instance.

Related: openscanhub/openscanhub#228 (comment)

@lzaoral
Copy link
Member Author

lzaoral commented Feb 20, 2024

@praiskup It seems that Differential PyLint reports a problem in a piece of code that was edited in this PR. 🤔

Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we handle it better when someone uses both --scrub and --no-clean?

py/csmock Outdated Show resolved Hide resolved
@lzaoral lzaoral requested a review from kdudka February 21, 2024 12:00
@lzaoral lzaoral changed the title csmock: add --scrub option csmock: add --scrub-on-exit option Feb 21, 2024
... to pass --scrub=all to the underlying mock instance.

Related: openscanhub/openscanhub#228 (comment)
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the update!

@lzaoral lzaoral merged commit af84d2f into csutils:main Feb 26, 2024
42 of 43 checks passed
@lzaoral lzaoral deleted the add-scrub-support branch February 26, 2024 16:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants