Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keras-Version: in Model-Definition DnCNN() the parameter use_bnorm is faulty? #53

Open
mullanptr opened this issue Feb 21, 2019 · 2 comments

Comments

@mullanptr
Copy link

Hello,

In the Keras Version, in main_train.py the function DnCNN (where the model is defined) has a parameter use_bnorm.
What the name of the parameter implies to me, is that you can specify whether to use batch-normalization, or not.

However, that's not what it does. There will be a Layer for Batch-Normalization included, always.
I assume this is just an indention error, with the if-clause above, isn't it?
What it now does, is only affecting the layer counter...

@mullanptr
Copy link
Author

Ahh sorry - maybe this can be closed again. Seems like I applied an auto-indention -- which messed up the original indention...

So yes the the use_bnorm can be used to include or exclude Batch-Normalization.

Only comment I have remaining is, that a small whitespace within the if-clause is present, which can mess up auto-indention...

@zaccharieramzi
Copy link

zaccharieramzi commented Dec 6, 2019

No I think you are right, the batch normalization used in the if clause governed by use_bnorm is commented out. The batch normalization is therefore always used, no matter the value of use_bnorm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants