Drop python 3.9 #2526
Drop python 3.9 #2526
Conversation
This comment has been minimized.
This comment has been minimized.
maxnoe
force-pushed
the
drop_py39
branch
2 times, most recently
from
5b60f75
to
f2133c6
Compare
|
Checking the uncovered lines, it is all error conditions which we cannot really check in the tests reasonably. I deactivated the hard "wait=True" which makes the whole CI fail in case of sonarqube not being happy. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2526 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 233 232 -1
Lines 20056 20034 -22
=======================================
- Hits 18571 18551 -20
+ Misses 1485 1483 -2 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -272,7 +271,7 @@ def load_config_file(self, path: Union[str, pathlib.Path]) -> None: | |||
|
|
|||
| if path.suffix in [".yaml", ".yml"]: | |||
| # do our own YAML loading | |||
| with open(path, "r") as infile: | |||
There was a problem hiding this comment.
This feels a bit scary, prefer the more explicit version.
There was a problem hiding this comment.
"r" is the default and python won't ever change that, it would break everyone
| @@ -104,12 +104,12 @@ def test_signal_fraction(tmp_path, gamma_train_clf, proton_train_clf): | |||
| ], | |||
| ) | |||
|
|
|||
| with open(log_file, "r") as f: | |||
| with open(log_file) as f: | |||
There was a problem hiding this comment.
prefer it when the open is explicit about being a read.
This comment has been minimized.
This comment has been minimized.
1 similar comment
Analysis Details0 Issues
Coverage and Duplications
Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
The drop schedule according to NEP 29 says to drop 3.9 in the first week of April and the newer SPEC https://scientific-python.org/specs/spec-0000/ already dropped it.
So I think we should follow and for 0.21, also drop 3.9.
I used
ruff --select=UPto check what can be changed and opted for now not converting every.formatto anf-stringand also didn't remove explicitencoding='utf-8'arguments as "explicit is better than implicit":