-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade of data training #58
Upgrade of data training #58
Conversation
|
||
|
||
def CTAMARS_radii(camera_name): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably doesn't even need to be a function, right? Nothing inside is computed or changes. Why not just make it a module-level variable called CTAMARS_RADII?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right.
Would you prefer I do it here or I keep it a small fix for later?
It's a bit hard to separate the main changes from re-formatting, but I guess the biggest changes are just to support the ctapipe-0.9.1 container name changes. This can be considered a first step on the way to fully using the new features of ctapipe-0.9.1 and above, like Otherwise, I don't see any big problems so far, but obviously this will be a bit superficial review, as can't easily test that the results are good. |
Yes, the upgrade to 0.9.1 was the main reason as it changed the API in some places. |
From the point of view of physical performance, this PR updates the calibration and image extraction (from which the latest results come - the ones that got temporarily reverted during between ctapipe 0.9.1 and 0.10.1) plus it enables the "optical aberration" correction as it is done in CTAMARS. From the data point of view, the variables related to image parameters are the same as in ctapipe (even though the format is still a single table) and the (optional) images file is merged with the rest so 1 run from plus other minor changes |
Requirements
Description
This is a big upgrade, targeting various parts of the pipeline up to DL2/a.
write_dl1
has becomedata_training
(1/2 of issue Give appropriate names to the scripts that produce data level information #53 )