Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade of DL2 production #77

Merged
merged 10 commits into from Dec 9, 2020

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Oct 31, 2020

Summary description

  • upgrades compatible with ctapipe 0.9.1
  • upgrades compatible with the newer version of data training

Requirements

Caveats

  • images still saved in a separate file (we should decide if the DL2 tool should let the user save images (I guess yes)
  • model parameters are hardcoded in the script, but they should be read from the model configuration file
  • I added telescope-wise estimated energy to the parameters for the gamma/hadron classifier which means that this information should be recorded soon

- added debug option
- fixed bugs
- improved data saving
@HealthyPear HealthyPear added enhancement New feature or request fix A PR that fixes a bug or a wrong behaviour. labels Oct 31, 2020
@HealthyPear HealthyPear added this to the Release 0.4 milestone Oct 31, 2020
@HealthyPear HealthyPear added this to In progress in Pipeline features and enhancements via automation Oct 31, 2020
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #77 (518642a) into master (e1239d0) will decrease coverage by 0.75%.
The diff coverage is 0.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   31.66%   30.91%   -0.76%     
==========================================
  Files          20       20              
  Lines        2201     2258      +57     
==========================================
+ Hits          697      698       +1     
- Misses       1504     1560      +56     
Impacted Files Coverage Δ
protopipe/scripts/write_dl2.py 5.90% <0.81%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1239d0...518642a. Read the comment docs.

@HealthyPear HealthyPear marked this pull request as ready for review December 7, 2020 13:53
kosack
kosack previously approved these changes Dec 8, 2020
Copy link
Contributor

@kosack kosack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one a few very minor comments (you can ignore or fix). Otherwise, looks fine, and this will be useful to look at when we implement the standard ctapipe Dl2 tool.

protopipe/scripts/write_dl2.py Outdated Show resolved Hide resolved
protopipe/scripts/write_dl2.py Outdated Show resolved Hide resolved
Pipeline features and enhancements automation moved this from In progress to Reviewer approved Dec 8, 2020
Pipeline features and enhancements automation moved this from Reviewer approved to Review in progress Dec 9, 2020
Pipeline features and enhancements automation moved this from Review in progress to Reviewer approved Dec 9, 2020
@HealthyPear HealthyPear merged commit d7a9b90 into cta-observatory:master Dec 9, 2020
Pipeline features and enhancements automation moved this from Reviewer approved to Done Dec 9, 2020
@HealthyPear HealthyPear deleted the upgrade-writeDL2 branch December 9, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix A PR that fixes a bug or a wrong behaviour.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants