Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all other notebooks and their docs version #76

Merged

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Oct 30, 2020

Summary description

  • updated all notebooks (apart from the calibration one which is taken care of by PR Upgrade calibration benchmarks #59 ) using results from the analysis of what will be protopipe 0.4.0dev.

Note

Due to some dependencies conflict between ctapipe >= 0.9.1 (and its dependencies) and the old version of gammapy used by the old version of the performnce step, I decided to add the pyirf support directly to the next version.

This means that,

  • this PR requires also the PRs related to this additional features (see Requirements section),
  • the IRF+Sensitivity notebook will get updated

Requirements

TODOs

@HealthyPear HealthyPear added documentation Documentation or services hosting it benchmarks labels Oct 30, 2020
@HealthyPear HealthyPear added this to the Release 0.4 milestone Oct 30, 2020
@HealthyPear HealthyPear added this to In progress in Pipeline features and enhancements via automation Oct 30, 2020
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@HealthyPear HealthyPear marked this pull request as ready for review January 18, 2021 11:53
@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #76 (f4ceedf) into master (70cdb0b) will decrease coverage by 0.17%.
The diff coverage is 26.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   36.99%   36.81%   -0.18%     
==========================================
  Files          17       18       +1     
  Lines        1768     1798      +30     
==========================================
+ Hits          654      662       +8     
- Misses       1114     1136      +22     
Impacted Files Coverage Δ
protopipe/mva/utils.py 11.34% <0.00%> (ø)
protopipe/perf/utils.py 24.52% <0.00%> (-0.97%) ⬇️
protopipe/scripts/build_model.py 15.21% <ø> (ø)
protopipe/scripts/model_diagnostic.py 6.76% <ø> (ø)
protopipe/perf/temp.py 26.47% <26.47%> (ø)
protopipe/scripts/make_performance_EventDisplay.py 21.78% <40.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70cdb0b...f4ceedf. Read the comment docs.

@HealthyPear HealthyPear mentioned this pull request Jan 25, 2021
9 tasks
Pipeline features and enhancements automation moved this from Review in progress to Reviewer approved Feb 1, 2021
@HealthyPear HealthyPear merged commit e8a51f1 into cta-observatory:master Feb 1, 2021
Pipeline features and enhancements automation moved this from Reviewer approved to Done Feb 1, 2021
@HealthyPear HealthyPear deleted the upgrade-other_notebooks branch February 1, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks documentation Documentation or services hosting it
Development

Successfully merging this pull request may close these issues.

None yet

2 participants