Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails with python 3.11.4 #8

Open
HealthyPear opened this issue Jul 14, 2023 · 0 comments · May be fixed by #17
Open

Installation fails with python 3.11.4 #8

HealthyPear opened this issue Jul 14, 2023 · 0 comments · May be fixed by #17
Labels
bug Something isn't working dependencies
Milestone

Comments

@HealthyPear
Copy link
Member

HealthyPear commented Jul 14, 2023

This happens because the pinned version of numpy (1.21.5) is too old - the latest version of numpy is 1.25.1.

There are 2 different ways to fix the problem:

Keep up with the future

This is what I do on development code and it's my recommendation.

Since this project is in an early development phase, I would suggest not pinning any version aside from python>=3.8 and using the latest releases of the required dependencies.

Only if there is a bug upstream for a dependency its version should be pinned.

I tested this and it works, but there are not enough tests in this project to be sure of the consequences.

lazy solution

requires-python = ">=3.8<3.11"

this might be more stable, but has the drawback that you will never be forced to use the latest performance features so you might lose the possibility to make the code faster and/or easier to read and maintain

Considering that you are not working on or maintaining a release branch, I would go for solution 1.

Whatever the choice, I am able to fix this issue with a PR if you want.

@HealthyPear HealthyPear added bug Something isn't working dependencies labels Jul 14, 2023
@HealthyPear HealthyPear linked a pull request Jun 27, 2024 that will close this issue
@HealthyPear HealthyPear added this to the 0.1.0 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant