Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of some clang warnings #102

Closed
GoogleCodeExporter opened this issue Jan 31, 2016 · 3 comments
Closed

Fix of some clang warnings #102

GoogleCodeExporter opened this issue Jan 31, 2016 · 3 comments

Comments

@GoogleCodeExporter
Copy link

Compiling an empty program that includes rapidjson with clang -Weverything 
leads to 
warning related to typos and syntax problems in the doxygen commands
The trivial patch attached resolves the issue.
Another warning persists but I believe it's a false positive. It could be nice, 
however, to be able to compile
warnings-free with -Weverything (a policy in my project) even if it the 
compiler wrong here.
The problem is that you use the \implements command to inform the 
implementation of a concept by a class, 
while clang checks that the actual inheritance relationship. The second patch 
fix the controversial warning.

Original issue reported on code.google.com by nicola.g...@gmail.com on 7 Mar 2014 at 4:42

Attachments:

@GoogleCodeExporter
Copy link
Author

EDIT: The second attached patch fixes only one of the points where the issue 
arise, just to give an example

Original comment by nicola.g...@gmail.com on 7 Mar 2014 at 4:49

@GoogleCodeExporter
Copy link
Author

Original comment by milo...@gmail.com on 20 Jun 2014 at 11:21

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

This commit should have fixed some warnings. This commit has been merged to 
master branch.

https://github.com/miloyip/rapidjson/commit/be8433737fde41827ab8b7c9477b75c10661
e049

Original comment by milo...@gmail.com on 30 Jun 2014 at 5:14

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant