Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma not allowed after last field of C++98 enum #49

Closed
GoogleCodeExporter opened this issue Jan 31, 2016 · 2 comments
Closed

Comma not allowed after last field of C++98 enum #49

GoogleCodeExporter opened this issue Jan 31, 2016 · 2 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. compile with gcc (eg 4.4.3) with -pedantic

What version of the product are you using? On what operating system?
0.11

Please provide any additional information below.

In rapidjson.h, there is one comma after the final field in the enum 'Type'. 
This is not allowed in C++98:

http://code.google.com/p/rapidjson/source/browse/trunk/include/rapidjson/rapidjs
on.h?r=131#251

Solution:
    kNumberType = 6,    //!< number
should be changed to
    kNumberType = 6     //!< number


Original issue reported on code.google.com by lundb...@gmail.com on 7 Dec 2012 at 9:47

@GoogleCodeExporter
Copy link
Author

I have pushed a fix for this issue to my GitHub fork at
https://github.com/pah/rapidjson/commit/69f40dc80

Original comment by philipp....@gmail.com on 1 Feb 2014 at 6:55

@GoogleCodeExporter
Copy link
Author

https://github.com/miloyip/rapidjson/commit/1ffd7b4a7d6c7064e6637e379c522cf4cdb1
d2f1

Original comment by milo...@gmail.com on 25 Jun 2014 at 4:11

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant