Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extractAllTo with a non-existing directory fails #2

Closed
jzaefferer opened this issue Mar 9, 2012 · 3 comments
Closed

extractAllTo with a non-existing directory fails #2

jzaefferer opened this issue Mar 9, 2012 · 3 comments

Comments

@jzaefferer
Copy link

Trying to extract a zip file to a directoy that doesn't exist yet fails:

TypeError: Cannot call method 'makeDir' of undefined
    at Object.writeFileTo (/Users/jza/dev/zip-test/node_modules/adm-zip/util/utils.js:77:31)

Changing exports.Utils.makeDir to module.exports.makeDir just causes another error, apparently the path resolving in mkdirSync is buggy.
@jzaefferer jzaefferer mentioned this issue Mar 9, 2012
Closed
@cthackers
Copy link
Owner

exports.Utils.makeDir can be replaced with mkdirSync since that is what makeDir calls. I'll submit the fix today along with some other new things i've been working on for the last few days. including synchronous deflater

@jzaefferer
Copy link
Author

Make sure to actually test mkdirSync, at least in my case (see #3) it didn't work either.

@cthackers
Copy link
Owner

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jzaefferer @cthackers