-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add incremental converter builder #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #34 +/- ##
===========================================
- Coverage 100.00% 97.59% -2.41%
===========================================
Files 5 5
Lines 267 291 +24
Branches 58 66 +8
===========================================
+ Hits 267 284 +17
- Misses 0 3 +3
- Partials 0 4 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@kervel please take a look over this and let me know what you think |
hello, i guess i would then use the def add_prefix(
self,
prefix: str,
uri_prefix: str,
prefix_synonyms: Optional[Collection[str]] = None,
uri_prefix_synonyms: Optional[Collection[str]] = None,
) -> None: this looks totally clear to me! Greetings, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33, suggested by @kervel
Demos
New prefixes can be added to an existing converter like in the following:
Similarly, an empty converter can be instantiated using an empty list for the
records
argument and prefixes can be added one at a time (note this currently does not allow for adding synonyms separately):