Address review comments (idaholab#21009)

cticenhour · May 13, 2022 · 1db14d7 · 1db14d7
1 parent 0f0b4e4
commit 1db14d7
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 6 deletions.
diff --git a/framework/doc/content/source/kernels/CoupledForce.md b/framework/doc/content/source/kernels/CoupledForce.md
@@ -2,8 +2,8 @@
 
 ## Description
 
-`CoupledForce` (and the AD version, `ADCoupledForce`) implements a source term within the domain $\Omega$ proportional to a coupled
-variable:
+`CoupledForce` (and the AD version, `ADCoupledForce`) implements a source term
+within the domain $\Omega$ proportional to a coupled variable:
 \begin{equation}
 \underbrace{-\sigma v}_{\textrm{CoupledForce}} + \sum_{i=1}^n \beta_i = 0 \in \Omega,
 \end{equation}

diff --git a/framework/include/kernels/Reaction.h b/framework/include/kernels/Reaction.h
@@ -14,7 +14,6 @@
 /**
  *  Implements a simple consuming reaction term with weak form $(\\psi_i, \\lambda u_h)$.
  */
-
 template <bool is_ad>
 class ReactionTempl : public GenericKernel<is_ad>
 {

diff --git a/framework/src/kernels/CoefReaction.C b/framework/src/kernels/CoefReaction.C
@@ -41,7 +41,8 @@ CoefReactionTempl<is_ad>::computeQpJacobian()
 {
   // This function will never be called for the AD version. But because C++ does
   // not support an optional function declaration based on a template parameter,
-  // we must keep this this template for all cases.
+  // we must keep this template for all cases.
+  mooseAssert(!is_ad, "In ADCoefReaction, computeQpJacobian should not be called. Check computeJacobian implementation.");
   return _coef * ReactionTempl<is_ad>::computeQpJacobian();
 }
 

diff --git a/framework/src/kernels/CoupledForce.C b/framework/src/kernels/CoupledForce.C
@@ -52,7 +52,8 @@ CoupledForceTempl<is_ad>::computeQpOffDiagJacobian(unsigned int jvar)
 {
   // This function will never be called for the AD version. But because C++ does
   // not support an optional function declaration based on a template parameter,
-  // we must keep this this template for all cases.
+  // we must keep this template for all cases.
+  mooseAssert(!is_ad, "In ADCoupledForce, computeQpJacobian should not be called. Check computeJacobian implementation.");
   if (jvar == _v_var)
     return -_coef * _phi[_j][_qp] * _test[_i][_qp];
   return 0.0;

diff --git a/framework/src/kernels/Reaction.C b/framework/src/kernels/Reaction.C
@@ -43,7 +43,8 @@ ReactionTempl<is_ad>::computeQpJacobian()
 {
   // This function will never be called for the AD version. But because C++ does
   // not support an optional function declaration based on a template parameter,
-  // we must keep this this template for all cases.
+  // we must keep this template for all cases.
+  mooseAssert(!is_ad, "In ADReaction, computeQpJacobian should not be called. Check computeJacobian implementation.");
   return _test[_i][_qp] * _rate * _phi[_j][_qp];
 }