Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code duplication and add AD versions of simple MOOSE objects #21009

Closed
cticenhour opened this issue May 11, 2022 · 0 comments · Fixed by #21010
Closed

Reduce code duplication and add AD versions of simple MOOSE objects #21009

cticenhour opened this issue May 11, 2022 · 0 comments · Fixed by #21010
Assignees
@cticenhour
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@cticenhour
Copy link
Member

Reason

Some MOOSE objects within the Reaction family (Reaction itself as well as CoefReaction, specifically), do not have AD versions. As these objects serve as building blocks for larger and more complicated objects, it makes sense to have a complete set (meaning non-AD and AD) for users to use. This can be accomplished using templates.

Further, CoupledForce and ADCoupledForce do not need to exist as separate files, and should be combined to reduce code duplication.

Design

Reaction --> ReactionTempl with Reaction and ADReaction (new)
CoefReaction --> CoefReactionTempl with CoefReaction and ADCoefReaction (new)
ADCoupledForce + CoupledForce --> CoupledForceTempl with both versions as before.

Impact

Adds useful objects (more software completeness) and reduce code duplication.
@cticenhour cticenhour added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels May 11, 2022
@cticenhour cticenhour self-assigned this May 11, 2022
cticenhour added a commit to cticenhour/moose that referenced this issue May 11, 2022
@cticenhour
Combine CoupledForce and ADCoupledForce to reduce code duplication (i…
cbed85a 
…daholab#21009)

Also restore ADCoupledForce error check test for using the same coupled and object variables
cticenhour added a commit to cticenhour/moose that referenced this issue May 11, 2022
@cticenhour
Add ADReaction (idaholab#21009)
5fb6239
cticenhour added a commit to cticenhour/moose that referenced this issue May 11, 2022
@cticenhour
Add ADCoefReaction (idaholab#21009)
163abfd
@cticenhour cticenhour mentioned this issue May 11, 2022
Merged
cticenhour added a commit to cticenhour/moose that referenced this issue May 11, 2022
@cticenhour
Add ADReaction (idaholab#21009)
27fc7d6
cticenhour added a commit to cticenhour/moose that referenced this issue May 11, 2022
@cticenhour
Add ADCoefReaction (idaholab#21009)
b7d8501
cticenhour added a commit to cticenhour/moose that referenced this issue May 12, 2022
@cticenhour
Combine CoupledForce and ADCoupledForce to reduce code duplication (i…
0dde90f 
…daholab#21009)

Also restore ADCoupledForce error check test for using the same coupled and object variables
cticenhour added a commit to cticenhour/moose that referenced this issue May 12, 2022
@cticenhour
Add ADReaction (idaholab#21009)
92c4313
cticenhour added a commit to cticenhour/moose that referenced this issue May 12, 2022
@cticenhour
Add ADCoefReaction (idaholab#21009)
e9c16ff
tophmatthews added a commit to tophmatthews/moose that referenced this issue May 12, 2022
@tophmatthews
combine and cleanup power law creep
05c1748 
Ref idaholab#21009
@tophmatthews tophmatthews mentioned this issue May 12, 2022
Merged
cticenhour added a commit to cticenhour/moose that referenced this issue May 13, 2022
@cticenhour
Add ADReaction (idaholab#21009)
4171269
cticenhour added a commit to cticenhour/moose that referenced this issue May 13, 2022
@cticenhour
Add ADCoefReaction (idaholab#21009)
0f0b4e4
cticenhour added a commit to cticenhour/moose that referenced this issue May 13, 2022
@cticenhour
Address review comments (idaholab#21009)
1db14d7
cticenhour added a commit to cticenhour/moose that referenced this issue May 13, 2022
@cticenhour
Address review comments (idaholab#21009)
621c467
tophmatthews added a commit to tophmatthews/moose that referenced this issue May 26, 2022
@tophmatthews
combine and cleanup power law creep
7ff539f 
Ref idaholab#21009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cticenhour cticenhour

Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ADReaction, ADCoefReaction, and combine CoupledForce objects cticenhour/moose
1 participant
@cticenhour