Save cleared notebooks as target version #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the target is version 3.
|
I would assume it changes all the notebooks only once (i.e. this is idempotent, it doesn't change the notebooks more than once with repeated application)? |
|
I believe so. I don't think it's worth doing this for all notebooks at the moment, though perhaps when we upgrade them all to v4. |
|
LGTM. |
|
Any concerns that need to be addressed before this is merged? |
|
Added a commit to add a command line argument for the target version. I think this should be merged once that commit gets a LGTM. |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this as requested in nengo/nengo#1129 to save all the notebooks as version 3 ... however, the result is not great because whether you set format 3 or 4, all notebooks in the Nengo repo will be changed. I think there's some disparity between what
nbconvertandnbformatare doing and what the actualnotebookare doing... but yeah, I don't use this script so I don't think it's worth tracking down the disparity. Leaving this here in any case if anyone finds it useful.