-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial about functions and tuning curves. #1129
Conversation
46e793c
to
e01fedb
Compare
Would it be a good idea to introduce the idea of the thresholding preset at the conclusion of this notebook? |
Yes! I wrote most of this quite a while ago (when there was no preset) and managed just now to look it over and finish it up. |
e01fedb
to
a2f75ff
Compare
Added the |
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"Let as look at the tuning curves first." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo. Should be "Let us"
Other than the typo, this LGTM. |
I will review this shortly, but one thing I noticed in the diff is that this notebook uses notebook version 4 while all the other notebooks we've kept as version 3 so far. The notebook version was changed in IPython 3.0, and can be read by IPython 2.4.1. so we would effectively be ending support for IPython 2.4.0 and below. 2.4.1 was released February 2015, and our tests already depend on
Feel free to propose other resolutions as well. |
How easy is it to generate v3 from v4? |
Pretty trivial: And there would be some programmatic way to do the same. |
If we can add that to the clear outputs script, I'm leaning towards keeping them in v3 for now. (Gotta call that script anyways to clear the outputs.) |
Let's keep them v3 for now (path of least resistance) as this would be nice to have for #1150. I'll modify the clear outputs script as well. |
Started looking at this in detail... one issue is that it uses In either case, since this will take some time to change, I'm going to leave this until after the 2.2.0 release, as it's already somewhat overdue. |
@tbekolay given that Nengo 2.2.0 has be released, is this ready to be merged? |
Probably not? It seems references to SPA should be removed? |
I rewrote the tutorial to remove references to SPA. Please review it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some squash commits to add this example to docs, among other things. Let me know if you're okay with these changes @jgosmann (in particular, feel free to revert any rewordings you disagree with in the notebook). I'll merge on your OK!
LGTM |
1811c6f
to
1ae6485
Compare
1ae6485
to
bf47e49
Compare
Description:
Adds a tutorial/example notebook.
Motivation and context:
Seemed useful to me to have.
Interactions with other PRs:
none
How has this been tested?
Ran all cells of the notebook.
Where should a reviewer start?
Read the notebook. 馃摉
How long should this take to review?
Types of changes:
Checklist: