-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeniedCharactersRegex broken in current NuGet build #52
Labels
Comments
Related: |
So you don’t want to do a NuGet release manually and keep all these bugs in until you can automate the process? 😅 |
Hey @poke - finally got around to this... didn't actually mean for it to run... but here we are.. v4 just went out! |
Spoke to soon, sent this to the local github nuget package repo.. not nuget for real |
Fixed for reals now.!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(tl;dr: You need to release fixes to NuGet)
So, this was a “fun” one. When attempting to use the library from NuGet,
DeniedCharactersRegex
doesn’t work and the library will always return an empty string, regardless of what you pass as input string.To reproduce
Simple example, create a new console application and add the dependency:
Edit the
Program.cs
to contain the following:Run the project:
Analysis
As it turns out, the following code is the problem:
Slugify/src/Slugify.Core/SlugHelper.cs
Lines 49 to 51 in e35bf8d
In the released NuGet version, this appears to be compiled to the following:
Originally, I thought this was some compiler optimization bug where it would inline the
ToString()
call here. But looking further, I realized that the released NuGet version is actually a bit older and this is actually the real code there:Slugify/src/Slugify.Core/SlugHelper.cs
Lines 49 to 50 in e9c5e89
Sooo, this was fixed in #22, and apparently that change never made it onto NuGet (along with some of the other fixes that happened last year). So can you publish a new version to NuGet soon? 😁
The text was updated successfully, but these errors were encountered: