Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write module tests for existing core modules #461

Open
Tapsi opened this issue Jan 25, 2019 · 2 comments
Open

write module tests for existing core modules #461

Tapsi opened this issue Jan 25, 2019 · 2 comments

Comments

@Tapsi
Copy link
Collaborator

Tapsi commented Jan 25, 2019

Just do it! :)

@ctomni231
Copy link
Owner

Okay, currently we have the following modules:

  • gamecontroller
  • input
  • JSlix
  • loop_manager
  • performance
  • screen
  • starter
  • state
  • statemachine
  • test
  • tween

We have tests only for two of the modules so far:

  • statemachine
  • test

How extensive do we want these tests to be:

  • Should we have tests on functions that require external files, and where would those test external files be stored?
  • Should we just test the essentials, or is this a robust ‘test everything’ suite?
  • Is tests important enough to invoke a ‘no test, no pull request’ policy?
  • Should we allow tests only to be available on debug builds, and leave them off release builds?

Let me know what you think.

@Tapsi
Copy link
Collaborator Author

Tapsi commented Jan 27, 2019

Focus on decoupled modules with logic heavy tasks.

For now I think these ones need tests:

  • gamecontroller
  • input (=> multi key handling)
  • screen (=> screen change mechanic)
  • statemachine
  • tween

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants