Add support to store and retrieve file descriptors in the service manager #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliakremmyda
force-pushed
the
working_with_fds
branch
from
a49bc45
to
22d023f
Compare
…ager.
Adds the bindings for sd_pid_notify_with_fds and sd_listen_fds_with_names
functions.
`notify_with_fds` method can send a file descriptor with a name to
service manager to store and to pass it to the main process again on next
invocation.
sample use:
```
read_fd, write_fd = IO.pipe
state = {
FDSTORE: 1,
FDNAME: pid
}
SystemdDaemon::Notify.notify_with_fds(0, state, read_fd.to_i)
```
`listen_fds_with_names` method checks if there are any file descriptors
passed and if there are, it returns a hash with their names as keys and
their descriptors as values.
sample use:
```
fds_hash = SystemdDaemon::Notify.listen_fds_with_names
# fds_hash = {"5304"=>3, "5301"=>4, "5298"=>5, "5295"=>6}
```
For more details you can check sd_notify(3) and sd_listen_fds(3).
oliakremmyda
force-pushed
the
working_with_fds
branch
from
22d023f
to
9e3cbef
Compare
ctrochalakis
reviewed
Mar 7, 2019
|
|
||
| def test_listen_fds_with_names | ||
| expected_names = { "bar" => 4, "foo" => 3 } | ||
| with_env('LISTEN_FDNAMES' => expected_names.keys.reverse.join(':'), |
There was a problem hiding this comment.
.reverse feels a bit odd. The names should be ordered by their fd number, and this is not explicit. I'd suggest to just hard-code the value and add a comment stating that order is important. e.g.
'LISTEN_FDNAMES' => "foo:bar", # ordered by fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the bindings for sd_pid_notify_with_fds and sd_listen_fds_with_names
functions.
notify_with_fdsmethod can send a file descriptor with a name toservice manager to store and to pass it to the main process again on next
invocation.
sample use:
listen_fds_with_namesmethod checks if there are any file descriptorspassed and if there are, it returns a hash with their names as keys and
their descriptors as values.
sample use:
For more details you can check sd_notify(3) and sd_listen_fds(3).