Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Support joins with distinct #5340

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

gandronchik
Copy link
Contributor

No description provided.

@gandronchik gandronchik requested a review from a team as a code owner September 22, 2022 12:22
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 76.17% // Head: 76.18% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (99e1b7d) compared to base (a706258).
Patch coverage: 93.33% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5340   +/-   ##
=======================================
  Coverage   76.17%   76.18%           
=======================================
  Files         275      275           
  Lines       33689    33702   +13     
  Branches     2900     2900           
=======================================
+ Hits        25664    25675   +11     
- Misses       7737     7739    +2     
  Partials      288      288           
Flag Coverage Δ
cube-backend 60.83% <ø> (ø)
cubesql 84.48% <93.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/rewrite/mod.rs 92.85% <ø> (ø)
rust/cubesql/cubesql/src/compile/mod.rs 91.03% <85.71%> (-0.01%) ⬇️
...t/cubesql/cubesql/src/compile/rewrite/converter.rs 91.87% <100.00%> (-0.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gandronchik gandronchik merged commit da4304f into master Sep 30, 2022
@gandronchik gandronchik deleted the cubesql-joins-distinct branch September 30, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants