Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-orchestrator): pre-aggs build range queries cache key alignment #5377

Merged

Conversation

buntarb
Copy link
Contributor

@buntarb buntarb commented Sep 28, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 60.15% // Head: 60.11% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (7ae80ca) compared to base (b77f33b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5377      +/-   ##
==========================================
- Coverage   60.15%   60.11%   -0.04%     
==========================================
  Files         140      140              
  Lines       11684    11691       +7     
  Branches     2853     2859       +6     
==========================================
  Hits         7028     7028              
- Misses       4368     4375       +7     
  Partials      288      288              
Flag Coverage Δ
cube-backend 60.11% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...y-orchestrator/src/orchestrator/PreAggregations.ts 78.76% <0.00%> (-0.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@buntarb buntarb marked this pull request as ready for review September 28, 2022 15:02
@buntarb buntarb requested a review from a team as a code owner September 28, 2022 15:02
@buntarb buntarb merged commit 5896c4a into master Sep 28, 2022
@buntarb buntarb deleted the bugfix/pre-aggs_build_range_queries_cache_key_mismatch branch September 28, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant