Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Us RichText Editor issue #48

Closed
Dirty-Butter opened this issue Jan 11, 2015 · 7 comments
Closed

Contact Us RichText Editor issue #48

Dirty-Butter opened this issue Jan 11, 2015 · 7 comments
Assignees
Milestone

Comments

@Dirty-Butter
Copy link

HTML formatting within the Content Box is not working, even when using Source Code setting - haven't tested any other documents yet.

@bhsmither
Copy link
Contributor

The Sanitize class no longer uses a set of exempted POST keys. Thus, the value for every POST key gets sent through the _safety() function.

In _safety(), the value is run through a FILTER_SANITIZE_STRING which strips out HTML tags.

This might not be a quick fix.

@Dirty-Butter
Copy link
Author

Is that what that setting about parsing smarty is for?

On January 10, 2015, at 8:21 PM, Brian Smither notifications@github.com wrote:

The Sanitize class no longer uses a set of exempted POST keys. Thus, the value for every POST key gets sent through the _safety() function.

In _safety(), the value is run through a FILTER_SANITIZE_STRING which strips out HTML tags.

This might not be a quick fix.


Reply to this email directly or view it on GitHub.

@bhsmither
Copy link
Contributor

HTML tags use the open-angle and close-angle. Smarty tags use the open-brace and close-brace and will survive sanitation. The Sanitizer applies to all input

I do not yet know what "Parse Smarty Tags" will do. I think it does not allow a POSTed value to escape sanitization.

@Dirty-Butter
Copy link
Author

So how can I get v6 to allow simple paragraph, font color editing, etc. in the document boxes? Or is this a bug? It does save a simple text color change to the provided Homepage document, but it would not save a highlight text color, even though the editor has that as a choice.

@bhsmither
Copy link
Contributor

I see the Sanitizer stripping out all HTML tags, so how a simple text color change got saved, I don't know.

Is this a bug? I would say so since you reported here.

@Dirty-Butter
Copy link
Author

Documents are working correctly for me now, but not sure why. I have had trouble getting CC cache cleared. There doesn't seem to be a way within v6 to turn off cache, and FF is being stubborn, too.

Contact Us form has no language choices (v5 didn't either), but it will NOT save formatting changes. Reverts to plain text. Very confusing to me.

@abrookbanks abrookbanks added this to the 6.0.0b2 milestone Jan 13, 2015
@abrookbanks abrookbanks self-assigned this Jan 13, 2015
@abrookbanks
Copy link
Member

I can't reproduce this but I think this is due to an earlier cache bug which is now fixed. The admin CP now clears the cache on each page load rather than trying to decide when bits need clearing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants