Changed to vector #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bond-009
reviewed
Nov 25, 2017
moderator.lua
Outdated
| @@ -96,12 +96,12 @@ function HandleLightningCommand(Split, Player) | |||
| local LookPos = GetPlayerLookPos(Player) | |||
| if Split[2] == nil then | |||
| if LookPos == nil then | |||
| Player:GetWorld():CastThunderbolt(Player:GetPosX(), Player:GetPosY(), Player:GetPosZ()) | |||
| Player:GetWorld():CastThunderbolt(Vector3i(Player:GetPosX(), Player:GetPosY(), Player:GetPosZ())) | |||
There was a problem hiding this comment.
cPlayer has a GetPosition method.
There was a problem hiding this comment.
Player:GetPosition() uses Vector3d, but CastThunderbolt requires Vector3i.
There was a problem hiding this comment.
Yes, you could do ‘Vector3i(Player:GetPosition())’ , right?
Bond-009
reviewed
Nov 25, 2017
| @@ -178,7 +178,7 @@ function HandleAntiOchCommand(Split, Player) | |||
| cRoot:Get():BroadcastChat("...lobbest thou thy Holy Hand Grenade of Antioch towards thy foe,") | |||
| cRoot:Get():BroadcastChat("who being naughty in My sight, shall snuff it.") | |||
| end | |||
| Player:GetWorld():SpawnPrimedTNT(LookPos.x, LookPos.y, LookPos.z, 35) | |||
| Player:GetWorld():SpawnPrimedTNT(Vector3d(LookPos.x, LookPos.y, LookPos.z), 35) | |||
There was a problem hiding this comment.
Wouldn't Vector3d(LookPos) work too?
There was a problem hiding this comment.
Not with the current approach. LookPos is a table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes messages about deprecated parameters.